Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Fix generation of reserved words in object api (#7106) #7115

Merged
merged 16 commits into from
Feb 22, 2022
Merged

[TS] Fix generation of reserved words in object api (#7106) #7115

merged 16 commits into from
Feb 22, 2022

Conversation

tira-misu
Copy link
Contributor

Fix generation of TS object api: Reserved words are not escaped.
In addition reserved word "argument" was missing in reserved words

tira-misu and others added 16 commits October 1, 2019 07:51
@tira-misu
Merge pull request #2 from google/master
64639a2 
Pull from google/flatbuffers
@tira-misu
Fix C/C++ Create<Type>Direct with sorted vectors
1d907c5 
If a struct has a key the vector has to be sorted. To sort the vector
you can't use "const".
@tira-misu
Changes due to code review
7827687
@tira-misu
Improve code readability
a78916b
@tira-misu
Merge branch 'master' of https://github.com/tira-misu/flatbuffers int…
0d9e229 
…o master
@tira-misu
Add generate of JSON schema to string to lib
163d43b 
* option indent_step is supported
@tira-misu
Remove unused variables
2793d38
@tira-misu
Fix break in test
79cd673
@tira-misu
Fix style to be consistent with rest of the code
6085fe1
@tira-misu
Merge branch 'master' of https://github.com/tira-misu/flatbuffers int…
7ae0e9d 
…o master
@tira-misu
Merge remote-tracking branch 'upstream/master' into master
0219f66
@tira-misu
Merge branch 'master' of https://github.com/google/flatbuffers
8643e11
@tira-misu
Merge branch 'google:master' into master
b837543
@tira-misu
[TS] Fix reserved words as arguments (google#6955)
eff8031
@tira-misu
Merge remote-tracking branch 'github/master'
3aa4f37
@tira-misu
[TS] Fix generation of reserved words in object api (google#7106)
fd6a5bb
@github-actions github-actions bot added c++ codegen Involving generating code from schema javascript typescript labels Feb 21, 2022
@dbaileychess dbaileychess merged commit 5ac0367 into google:master Feb 22, 2022
@dbaileychess
Copy link
Collaborator

Thanks!

@dbaileychess dbaileychess mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ codegen Involving generating code from schema javascript typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tira-misu @dbaileychess